Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bandit to CI and address reported issues #329

Merged
merged 1 commit into from
Mar 5, 2021
Merged

Conversation

bdraco
Copy link
Contributor

@bdraco bdraco commented Mar 5, 2021

The CI Fix is in #320 which needs to go in first

This one will need to be rebased as it will conflict with the other open PRs.

@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #329 (ef1ea3c) into dev (4f91df0) will increase coverage by 1.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #329      +/-   ##
==========================================
+ Coverage   89.04%   90.11%   +1.06%     
==========================================
  Files          19       19              
  Lines        1881     1882       +1     
  Branches      218      218              
==========================================
+ Hits         1675     1696      +21     
+ Misses        158      137      -21     
- Partials       48       49       +1     
Impacted Files Coverage Δ
pyhap/hap_handler.py 81.59% <100.00%> (+5.56%) ⬆️

@bdraco bdraco force-pushed the bandit branch 2 times, most recently from c3fa3fc to 39f8c2e Compare March 5, 2021 18:21
@bdraco bdraco marked this pull request as ready for review March 5, 2021 18:21
@ikalchev ikalchev merged commit 044062d into ikalchev:dev Mar 5, 2021
@ikalchev
Copy link
Owner

ikalchev commented Mar 5, 2021

Will release over the weekend, @bdraco

@bdraco
Copy link
Contributor Author

bdraco commented Mar 5, 2021

Will release over the weekend, @bdraco

Perfect, thank you!

@bdraco
Copy link
Contributor Author

bdraco commented Mar 5, 2021

Just realized we are up to 90% on codecov 👍

@ikalchev
Copy link
Owner

ikalchev commented Mar 5, 2021

It's all you mate :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants