Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding node pool ssh keys to output #69

Merged
merged 1 commit into from
Jan 10, 2023
Merged

adding node pool ssh keys to output #69

merged 1 commit into from
Jan 10, 2023

Conversation

k11h-de
Copy link
Contributor

@k11h-de k11h-de commented Dec 15, 2022

Hi iits,

In order to do troubleshooting, it is required to login into the node pools nodes sometimes.
This PR is adding the pub and private ssh keys to the output.

@victorgetz
Copy link
Member

Hi sorry we had a big project and all of our CloudOps Consultants had no time for the ProjectFactory. We will take a look today

@k11h-de
Copy link
Contributor Author

k11h-de commented Jan 10, 2023

Hi @victorgetz
Do you think it makes sense to merge this PR? I would love to see these terraform exports.

Thanks and all the best
Karsten

@canaykin
Copy link
Contributor

Hi Karsten,

I will approve the merge request but please note that the default ssh keys were removed from the jumphost module and I intend to do the same for the CCE nodes as soon as it becomes a possibility within the OTC provider.

That being said, I would still recommend using the post_install variable to inject personalized public keys via a script and not sharing private key(s) across multiple admins. This way it will also stay compatible when we choose to remove the default key approach.

Alternatively, I can also recommend using kubectl debug node/<node-name> -it --image=<image name> to use a more kubernetes native way to check hosts. This of course is only possible if the node can run a pod so it will not apply to situations where the kubelet is down.

Best,
Can.

@canaykin canaykin merged commit b9f44ab into iits-consulting:master Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants