Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit to the curated list of awesome lists? #48

Closed
Spone opened this issue Sep 10, 2018 · 13 comments · Fixed by #90
Closed

Submit to the curated list of awesome lists? #48

Spone opened this issue Sep 10, 2018 · 13 comments · Fixed by #90

Comments

@Spone
Copy link

Spone commented Sep 10, 2018

I suggest this list should be submitted to https://github.com/sindresorhus/awesome

Here are the instructions: https://github.com/sindresorhus/awesome/blob/master/pull_request_template.md

@ibnesayeed
Copy link
Contributor

I tried adding it to their list, which would have made it more discoverable, but their requirements are quite strict and this list is failing their lint miserably. While I can fix a few things, only maintainers (@ruebot & @anjackson ) of the repo can do the rest.

/tmp/awesome-web-archiving$ awesome-lint
✖ Linting

  README.md:9:3
  ✖    1:1    Missing file contributing.md                                                     remark-lint:awesome-contributing
  ✖    1:1    The repository should have "awesome" as a GitHub topic                           remark-lint:awesome-github
  ✖    1:1    License was not detected by GitHub                                               remark-lint:awesome-github
  ✖    1:1    Missing or invalid Table of Contents                                             remark-lint:awesome-toc
  ✖    1:26   Invalid badge source                                                             remark-lint:awesome-badge
  ✖    9:3    Incorrect indentation before bullet: remove 3 spaces                             remark-lint:list-item-bullet-indent
  ✖    9:6    Invalid list item link URL                                                       remark-lint:awesome-list-item
  ✖   10:3    Incorrect indentation before bullet: remove 3 spaces                             remark-lint:list-item-bullet-indent
  ✖   10:6    Invalid list item link URL                                                       remark-lint:awesome-list-item
  ✖   11:3    Incorrect indentation before bullet: remove 3 spaces                             remark-lint:list-item-bullet-indent
  ✖   11:6    Invalid list item link URL                                                       remark-lint:awesome-list-item
  ✖   12:8    Incorrect indentation before bullet: remove 2 spaces                             remark-lint:list-item-bullet-indent
  ✖   12:10   Invalid list item link URL                                                       remark-lint:awesome-list-item
  ✖   13:8    Incorrect indentation before bullet: remove 2 spaces                             remark-lint:list-item-bullet-indent
  ✖   13:10   Invalid list item link URL                                                       remark-lint:awesome-list-item
  ✖   14:8    Incorrect indentation before bullet: remove 2 spaces                             remark-lint:list-item-bullet-indent
  ✖   14:10   Invalid list item link URL                                                       remark-lint:awesome-list-item
  ✖   15:8    Incorrect indentation before bullet: remove 2 spaces                             remark-lint:list-item-bullet-indent
  ✖   15:10   Invalid list item link URL                                                       remark-lint:awesome-list-item
  ✖   16:8    Incorrect indentation before bullet: remove 2 spaces                             remark-lint:list-item-bullet-indent
  ✖   16:10   Invalid list item link URL                                                       remark-lint:awesome-list-item
  ✖   17:8    Incorrect indentation before bullet: remove 2 spaces                             remark-lint:list-item-bullet-indent
  ✖   17:10   Invalid list item link URL                                                       remark-lint:awesome-list-item
  ✖   18:3    Incorrect indentation before bullet: remove 3 spaces                             remark-lint:list-item-bullet-indent
  ✖   18:6    Invalid list item link URL                                                       remark-lint:awesome-list-item
  ✖   19:3    Incorrect indentation before bullet: remove 3 spaces                             remark-lint:list-item-bullet-indent
  ✖   19:6    Invalid list item link URL                                                       remark-lint:awesome-list-item
  ✖   26:5    Incorrect indentation before bullet: remove 1 space                              remark-lint:list-item-bullet-indent
  ✖   26:6    Invalid list item link                                                           remark-lint:awesome-list-item
  ✖   44:5    Incorrect indentation before bullet: remove 2 spaces                             remark-lint:list-item-bullet-indent
  ✖   44:61   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖   45:5    Incorrect indentation before bullet: remove 2 spaces                             remark-lint:list-item-bullet-indent
  ✖   46:5    Incorrect indentation before bullet: remove 2 spaces                             remark-lint:list-item-bullet-indent
  ✖   47:5    Incorrect indentation before bullet: remove 2 spaces                             remark-lint:list-item-bullet-indent
  ✖   47:123  List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖   50:5    Incorrect indentation before bullet: remove 2 spaces                             remark-lint:list-item-bullet-indent
  ✖   51:5    Incorrect indentation before bullet: remove 2 spaces                             remark-lint:list-item-bullet-indent
  ✖   53:5    Incorrect indentation before bullet: remove 2 spaces                             remark-lint:list-item-bullet-indent
  ✖   54:5    Incorrect indentation before bullet: remove 2 spaces                             remark-lint:list-item-bullet-indent
  ✖   55:5    Incorrect indentation before bullet: remove 2 spaces                             remark-lint:list-item-bullet-indent
  ✖   56:5    Incorrect indentation before bullet: remove 2 spaces                             remark-lint:list-item-bullet-indent
  ✖   57:5    Incorrect indentation before bullet: remove 2 spaces                             remark-lint:list-item-bullet-indent
  ✖   58:5    Incorrect indentation before bullet: remove 2 spaces                             remark-lint:list-item-bullet-indent
  ✖   77:53   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖   79:54   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖   81:58   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖   83:57   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖   85:47   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖   87:52   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖   89:52   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖   91:55   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖   93:56   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖   95:64   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖   97:57   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖   99:37   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  101:53   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  103:46   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  105:61   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  107:55   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  109:65   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  111:53   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  113:43   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  115:43   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  117:46   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  119:53   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  121:43   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  123:50   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  125:36   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  127:41   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  129:44   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  131:48   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  133:42   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  137:43   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  139:54   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  141:82   Text "OSX" should be written as "macOS"                                          remark-lint:awesome-spell-check
  ✖  149:39   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  151:39   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  153:71   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  155:5    Incorrect indentation before bullet: remove 2 spaces                             remark-lint:list-item-bullet-indent
  ✖  155:45   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  157:5    Incorrect indentation before bullet: remove 2 spaces                             remark-lint:list-item-bullet-indent
  ✖  157:68   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  159:5    Incorrect indentation before bullet: remove 2 spaces                             remark-lint:list-item-bullet-indent
  ✖  159:66   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  161:5    Incorrect indentation before bullet: remove 2 spaces                             remark-lint:list-item-bullet-indent
  ✖  161:47   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  161:110  Link to http://desires.dei.unipd.it/papers/paper4.pdf is dead                    remark-lint:no-dead-urls
  ✖  163:5    Incorrect indentation before bullet: remove 2 spaces                             remark-lint:list-item-bullet-indent
  ✖  169:62   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  173:3    Invalid list item link URL                                                       remark-lint:awesome-list-item
  ✖  175:68   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  177:48   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  179:53   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  181:53   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  183:50   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  185:72   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  187:55   Text "OSX" should be written as "macOS"                                          remark-lint:awesome-spell-check
  ✖  189:55   Text "OSX" should be written as "macOS"                                          remark-lint:awesome-spell-check
  ✖  191:68   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  193:44   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  199:69   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  201:64   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  207:51   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  211:58   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  213:66   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  217:73   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  221:117  List item description must end with proper punctuation                           remark-lint:awesome-list-item
  ✖  223:113  List item description must end with proper punctuation                           remark-lint:awesome-list-item
  ✖  225:131  List item description must end with proper punctuation                           remark-lint:awesome-list-item
  ✖  227:131  List item description must end with proper punctuation                           remark-lint:awesome-list-item
  ✖  229:110  List item description must end with proper punctuation                           remark-lint:awesome-list-item
  ✖  231:57   List item description must end with proper punctuation                           remark-lint:awesome-list-item
  ✖  233:49   List item description must end with proper punctuation                           remark-lint:awesome-list-item
  ✖  235:45   Text "MacOS" should be written as "macOS"                                        remark-lint:awesome-spell-check
  ✖  237:123  Text "MacOS" should be written as "macOS"                                        remark-lint:awesome-spell-check
  ✖  239:52   Text "MacOS" should be written as "macOS"                                        remark-lint:awesome-spell-check
  ✖  241:53   List item description must end with proper punctuation                           remark-lint:awesome-list-item
  ✖  243:52   List item description must end with proper punctuation                           remark-lint:awesome-list-item
  ✖  263:144  List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  264:60   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  271:1    Rules should use ---                                                             remark-lint:rule-style
  ✖  275:3    Link to https://addons.mozilla.org/en-US/firefox/addon/archivefacebook/ is dead  remark-lint:no-dead-urls
  ✖  275:85   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  277:87   List item link and description must be separated with a dash                     remark-lint:awesome-list-item
  ✖  279:65   List item link and description must be separated with a dash                     remark-lint:awesome-list-item

  125 errors

@ruebot
Copy link
Member

ruebot commented Feb 22, 2020

@ibnesayeed feel free to take it on, and let me or @anjackson know what needs to be changed admin-wise.

@ibnesayeed
Copy link
Contributor

I will sync my local repo after #74 is merged then will try to fix some of these lint issues.

@ibnesayeed
Copy link
Contributor

ibnesayeed commented Feb 25, 2020

@ruebot & @anjackson

  • Are you okay with the recommended CC0 license or some other Creative Commons license for this repo? Would like to add one yourself or should I add it in a PR?
  • Can you also add awesome in topics of the repo next to the awesome-list under the description of the repo.

@ibnesayeed
Copy link
Contributor

I found out that the license is already CC0, but it was inline, not as a separate file, so I am going to add it.

@ruebot
Copy link
Member

ruebot commented Feb 25, 2020

Can you also add awesome in topics of the repo next to the awesome-list under the description of the repo.

Done.

@ibnesayeed
Copy link
Contributor

Thanks @ruebot, if you are happy with the #75 PR, you may go ahead and merge that. Then I will draft a PR in the upstream awesome repo to get this list added there, after which, we should be able to close this issue.

@Spone
Copy link
Author

Spone commented Feb 25, 2020

Great to see progress on this! Thanks to everybody who contributed time :)

@ibnesayeed
Copy link
Contributor

Submitted to the awesome list for inclusion. sindresorhus/awesome#1704

@ibnesayeed
Copy link
Contributor

Please open this ticket as the PR is not merged in the meta list.

@ruebot
Copy link
Member

ruebot commented Mar 26, 2020

@ibnesayeed you had an actionable keyword in your PR. It closed because of you. If you did not intend that, please don't use them.

These changes are made to comply with the comments at sindresorhus/awesome#1704 (comment) in order to close #48.

@ruebot ruebot reopened this Mar 26, 2020
@ibnesayeed
Copy link
Contributor

Yes, it was an oversight on my end, I should have phrased the commit message better.

@ibnesayeed
Copy link
Contributor

sindresorhus/awesome#1704 is merged and tweeted so this issue can be closed now.

@ato ato closed this as completed Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants