Fix integration tests; Fix manifest-level service #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
What remains to be done before this can be merged? |
|
UCD's manifests are now failing osullivan parsing because of this bug. How can I help get this PR merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code change correctly handles valid manifests that include an array of services, which is common at the Wellcome and many other IIIF content providers. Previously, osullivan died with an exception when trying to parse these manifests.
Along the way, this PR also fixes stale integration tests that relied on outdated URIs for manifests at Princeton. That test code should probably be reviewed by @cbeer.
This PR replaces #61, which can be closed.