Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix accidental exclusion of default values #80

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Fix accidental exclusion of default values #80

merged 1 commit into from
Oct 6, 2022

Conversation

digitaldogsbody
Copy link
Member

The inclusion of exclude_unset=True in the JSON producing functions was preventing non-modified defaults (such as type from being included in the JSON output.

This PR fixes that, and also explicitly sets exclude_defaults to False and prevents it from being overridden by the kwargs.

@glenrobson
Copy link
Contributor

Discussed on call.

  • OK to merge

@digitaldogsbody digitaldogsbody merged commit 2fe9a83 into main Oct 6, 2022
@digitaldogsbody digitaldogsbody deleted the fix_defaults branch October 6, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helrond helrond Awaiting requested review from helrond

@azaroth42 azaroth42 Awaiting requested review from azaroth42

@glenrobson glenrobson Awaiting requested review from glenrobson

@p-galligan p-galligan Awaiting requested review from p-galligan

@giacomomarchioro giacomomarchioro Awaiting requested review from giacomomarchioro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@digitaldogsbody @glenrobson