-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic mkdocs documentation setup #75
Conversation
Looks great, agree not sure how to test other than to merge and see what happens. |
(build & deploy or build to check)
ok, I've updated the workflow so it will build docs in strict mode on pull requests (which required me to do a little docstring cleanup — if you look at previous builds you can see it failed), and then should build & publish on push to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work - thanks!
I'm afraid the build failed on master: https://github.com/iiif-prezi/iiif-prezi3/runs/6633389984?check_suite_focus=true |
@glenrobson sorry I haven't gotten back to this, was thinking to open a pr with a suggested fix but haven't had time. It seems like the mkdocs workflow action doesn't use the same environment as the workflow where we're installing dependencies. I think the simplest thing would be to build the docs similar to the way we build them on PRs (or maybe that exact same action), and then use a different GH action to publish. |
I think the |
this pr adds basic documentation setup
mkdocs
setup; pulled in the existingdocs/*.md
files, linked the main readme to be the index of the docs site, added a code reference file to generate docs from code docstrings using google formatGITHUB_TOKEN
secret to allow the deployshould be possible to create PR check to confirm documentation builds correctly, and maybe even check documentation coverage, but I'm less familiar with mkdocs than sphinx