Repository navigation
chore: clean up remaining iii-stream and pubsub references (MOT-3619) - #1353
Merged
Merged
Conversation
…d hover (MOT-3619)
…am triggers deprecated in docs (MOT-3619)
…config (MOT-3619)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 41 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. Review configuration: ⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (24)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (24)
💤 Files with no reviewable changes (3)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe changes mark legacy ChangesLegacy Trigger Deprecation
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The changes consistently mark legacy triggers as deprecated and remove them from the described unused configurations; no concrete user-facing failure is established, so the PR appears mergeable after normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 52.94% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 17 functions across 11 files. (10 skipped: 10 unsupported.) ✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit reads the trigger guide, Comment |
Contributor
skill-check — worker0 verified, 83 skipped (no docs/).
Four for four. Nicely done. |
Contributor
guibeira
marked this pull request as ready for review
October 8, 2026 20:45
…OT-3619) main drifted after #1329 (harness gained whatlang/regex; console-ui moved to iii-sdk 0.23.0). Adds whatlang 0.18.0 + allocator-api2 0.2.21 and dependency edges only; no existing crate version changes. Unblocks approval-gate rust lint + test and interface boot smoke.
andersonleal
added a commit
that referenced
this pull request
Oct 9, 2026
…rom ~37 min (#1359) * ci(judge-e2e): skip the Rust engine suite on JS-only shared changes packages/console-ui is a type-only surface and the root pnpm files only reach the judge UIs, yet a PR touching just those ran the full ~37 min real-engine suite (e.g. #1353, one .d.mts file). Keep the UI Vitest and tsc builds on those paths and gate the toolchain, cache, llama.cpp tools, engine install and engine tests on a change the engine suite builds. Claude-Session: https://claude.ai/code/session_01WQhvPNhJJpri8PUFLGuQ5s * ci(judge-e2e): build each shared unit once and llama.cpp CPU-only The engine step spent ~36 of 37 min compiling: llama.cpp from scratch for each of semif, decider, laya and clef (every CPU variant plus the Vulkan shaders), and eight separate workspaces rebuilding the same deps. The 11 cases themselves take ~27 s. - crates/llama-native: III_LLAMA_CPP_MINIMAL=1 builds one CPU module and no Vulkan (test-only; published builds are unchanged). - judge-e2e: one CARGO_TARGET_DIR for all suites plus the minimal build; drop rust-cache (PR-scoped, never reaches another PR, and it purges path crates) and the Vulkan apt step. Local mirror run: 11/11 pass in 245 s, llama.cpp built twice (judge-laya keeps its own opt-level 3 build). Claude-Session: https://claude.ai/code/session_01WQhvPNhJJpri8PUFLGuQ5s
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of MOT-3619 Phase 3: clean up the remaining iii-stream / pubsub references in the workers repo that are not part of a consumer migration (see iii-hq/iii#2281). 11 commits, one per area; no behavior change beyond removing unused iii-stream / pubsub config.
Changes
engine_builtinsdrops stream;stream/subscribetrigger docs marked deprecated.tests/manifest.rsguard (iii-stream is not a dependency) kept.ENGINE_BUILTIN_WORKERS).stream::and keep the!stream::setdeny, with comments explaining they cover the deprecated iii-stream.stream,stream:join,stream:leavetagged deprecated in completions and hover (3 new tests).docs/architecture/iii-worker-yaml.md; openwiki and console-uihooks.d.mtsexamples point at owned/state triggers.iii-pubsubremoved from the testkit engine config.Verification
.github/scriptspytest 304 passed / 3 skipped, openwiki 89/89; fmt and clippy clean where applicable.Follow-ups (not in this PR)
iii-state, which engine 0.24 refuses, so its ~60 engine-backed tests always self-skip; needs a standalone state worker in the testkit.template/andkanban/iii-browser-sdk.mdstill teachcreateStream; those skill files are generated from iii-hq/templates, so fix them there and re-sync.Cargo.lockis stale for--locked; the harness-e2e crate does not compile on the base commit.Summary by CodeRabbit
iii-streamand its related triggers and functions as deprecated across guidance, examples, and editor assistance.iii-streamfrom selected engine and example configurations while retaining existing restrictions on its functions.