Remove all setEncoding()'s by default. UTF-8 cannot safely be implied…#27
Open
NuSkooler wants to merge 3 commits intoiiegor:masterfrom
Open
Remove all setEncoding()'s by default. UTF-8 cannot safely be implied…#27NuSkooler wants to merge 3 commits intoiiegor:masterfrom
NuSkooler wants to merge 3 commits intoiiegor:masterfrom
Conversation
…. Callers can set this explicitly, or for example set their own processing in 'data' listeners
Author
|
@iiegor Any thoughts on this? |
DragonFly BSD Support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…. Callers can set this explicitly, or for example set their own processing in 'data' listeners.
I had to put this in my own fork for now - non-UTF8 encodings simply fail due to explicitly setting them to UTF-8. Callers can still use setEncoding() - or, for more advanced stuff (e.g. iconv, or the like), handle it in 'data' event.