Skip to content

Conversation

@ywpratama
Copy link

@ywpratama ywpratama commented Jan 16, 2025

Required: TBA
Commits history is mixed with commits not intended to be included in this draft pull request.
The list of what were done includes:

  1. Create a draft pull request for the project/justmip_rebase_magpie branch
  2. Rebase the draft PR against main
  3. Resolve conflicts
  4. Force push the rebase to the branch
  5. Together with Paul, rebasing and cleaning up the branch to exclude unwanted commits
    • The branch history is now cleaned up
  6. Yoga is currently identifying changes made to GAMS code and analysing potential approaches to add option to MAgPIE connection

How to review

Required: describe specific things that reviewer(s) must do, in order to ensure that the PR achieves its goal.
If no review is required, write “No review:” and describe why.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation.
  • Update release notes.

@CLAassistant
Copy link

CLAassistant commented Jan 16, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ywpratama ywpratama force-pushed the project/justmip_rebase_magpie branch 2 times, most recently from 4f3df86 to 480077d Compare January 20, 2025 08:55
jansteinhauser and others added 27 commits January 20, 2025 10:05
Also, remove cumulative cost accounting
Also, remove cumulative cost accounting
@ywpratama ywpratama force-pushed the project/justmip_rebase_magpie branch from 480077d to eb99273 Compare January 20, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants