Skip to content

Improve IAMCConversion #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
khaeru wants to merge 19 commits into
base: main
Choose a base branch
from
Draft

Improve IAMCConversion #456

khaeru wants to merge 19 commits into from

Conversation

@khaeru
Copy link
Member

@khaeru khaeru commented Nov 12, 2025

Closes #454.

How to review

TBA

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation.
  • Update doc/whatsnew.

@khaeru
Add test of #454 / IAMCConversion.add_tasks()
3451a21
@khaeru
Improve IAMCConversion
03bd3d7 
- Add optional rename=… argument.
- Add only sums needed for conversion, not all possible sums.
- Adjust logic for dimension renames:
  - Infer dimensions to rename from var_parts.
  - Don't mix defaults and explicit/user-supplied values.
  - Validate resulting arg.
@khaeru
Simplify .report.iamc() config handler
34afa6b 
Chain directly to IAMCConversion.{__init__,add_tasks}.
@khaeru khaeru self-assigned this Nov 12, 2025
@khaeru khaeru added enh New features or functionality report genno-based reporting and post-solve processing labels Nov 12, 2025
khaeru added 16 commits November 12, 2025 23:36
@khaeru
Move and rename .transport…add_iamc_store_write()
474e21b 
- Move out of .model.transport to general .report.util.
- Rename to store_write_ts().
- Adjust usage.
@khaeru
Add store_write_ts to .report.defaults()
23b4c54 
- Add keys "all::iamc+csv", "all::iamc+xlsx", etc. to defaults.
@khaeru
Use IAMCConversion directly in .transport.report
217921d
@khaeru
Use IAMCConversion directly in .report.compat
50a211a
@khaeru
Move short_hash .transport.workflow → .util
c6e61fd
@khaeru
Add .model.structure.get_technology_groups()
a67fb8a
@khaeru
Add .report.key.groups.t
fcc21fd 
…invoking get_technology_groups()
@khaeru
Simplify .iamc.compare()
b9e0d47
@khaeru
Improve select_allow_empty()
99c6adb 
- Preserve same units as input quantity.
- Drop dimensions if they would be dropped by select(), given the
  indexers.
@khaeru
Add .report.operator.groups_to_selectors()
4c055a9
@khaeru
Handle "Eps" = NA in .sim.data_from_file()
9849845
@khaeru
Add commodity to gas_extr* tech output annotations
31522a8 
- Adjust test expectations.
@khaeru
Set default target in IAMCConversion.add_tasks
9a15948 
This ensures "all::iamc" is created, if it does not already exist.
@khaeru
Handle GLB_zeros with node dim like "nd" or "nl"
6b490a0
@khaeru
Add module .report.gdp
fb8f55a 
- Replace reporting of GDP to IAMC structure in report/global.yaml.
- Add to default .report.Config.callback.
@khaeru
Add module .report.price
43bc5ef 
- Replace reporting of prices to IAMC structure in report/global.yaml.
- Add to default .report.Config.callback.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@r-aneeque r-aneeque Awaiting requested review from r-aneeque r-aneeque will be requested when the pull request is marked ready for review r-aneeque is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@khaeru khaeru

Labels

enh New features or functionality report genno-based reporting and post-solve processing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Handle quantities with 2+ n/y dims in IAMCConversion

1 participant

@khaeru