-
Notifications
You must be signed in to change notification settings - Fork 50
Swap macos-13 → -15-intel runners in CI #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1f8be76 to
42ebae1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #453 +/- ##
=======================================
- Coverage 75.5% 74.8% -0.7%
=======================================
Files 277 277
Lines 22674 22663 -11
=======================================
- Hits 17136 16974 -162
- Misses 5538 5689 +151
🚀 New features to boost your workflow:
|
|
The job I think this is because there are no pre-built binary wheels for JPype1 on Python 3.14/x86_64; see here. I tried to address this by dropping Python to 3.14 for this job (and the other |
glatterf42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me for the most part. Just one question about this failure that we see only on ubuntu-latest-py3.14-upstream >= 3.11.0:
FAILED message_ix_models/tests/model/transport/test_report.py::test_simulated_iamc - AssertionError: assert {'Energy Serv...nger|LDV|BEV'} <= {'Transport|S...nger|LDV|BEV'}
Extra items in the left set:
'Final Energy|Transportation|Bus'
'Energy Service|Transportation|Domestic Aviation'
Is that expected or should/could this be fixed by this PR, too?
Adapt to deprecation of macos-13 runners (actions/runner-images#13046).
- Remove associated test markers and usage.
Per actions/runner-images#13046:
macos-13runner images are deprecated and will become unavailable.macos-15-intelis available.The reason we were still using
macos-13is that message-ix-models still supports ixmp/message_ix v3.8 and v3.9. These versions neither (a) bundled binary GAMS libraries for arm64 (such as needed on themacos-latestrunner) nor (b) included iiasa/ixmp#532 that adapted JDBCBackend to locate these libraries within the local GAMS installation. Thus, tests for these versions can't be run on arm64 systems (likemacos-latest) and had to run onmacos-13, which is x86-64. The new-intelimage makes it possible to run the tests.How to review
PR checklist
Add or expand tests;coverage checks both ✅Add, expand, or update documentation.N/A; CI changes only.Update doc/whatsnewditto.