-
Notifications
You must be signed in to change notification settings - Fork 41
Migrate .engage.workflow and related tools #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2bb8eb8
to
c6f7a8f
Compare
- Adjust imports. - Type hint test functions.
- Adjust imports. - Type hint test functions.
- Adjust imports. - Type hint test functions.
- Adjust imports. - Type hint test functions.
this is removed by update_h2_blending() earlier in the workflow.
- pass information on the navigate demand-side scenario to the build_transport() function and through to the messageix-transport code. - produce distinct step names, e.g. "mt npi-act built" instead of "mt built", and also different ixmp scenario names.
change output file name to (1) indicate debug output and (2) match function name.
cf. discussion on iiasa/navigate-workflow#17.
select a set of values of the same length as len(info.y) to pass to make_io().
on the first pass of .buildings.pre_solve(), data["rc_act_2010"] is available from the base scenario; on subsequent passes, it is not/is empty, so do not attempt to use it.
- Use parametrized generics from default collections. - Import from collections.abc instead of typing.
- Copied from: https://github.com/iiasa/navigate-workflow - file definitions/scenario/scenarios.yaml - commit abb23814b7de3618ec4287ec014ddfce3e07c030 (2023-04-21) - Adjust code that reads this file to use the new location.
- Use path_fallback in .navigate.wp2.utils. - Change load_private_data → load_package_data in .buildings.build.load_config().
3eff177
to
4bc1cfa
Compare
Per the description, we expect the two coverage checks to fail on this PR:
I opened #352 for the work to add tests of this code. We will prioritize the pieces needed to make the NGFS BMT workflow operational. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to have worked exactly as intended, judging from the passing tests and the adjusted test coverage :)
- Remove XFAIL marks from iiasa/message_data#442. - Update expectations to match latest code. - Remove "message_buildings_dir" fixture.
4bc1cfa
to
f6e54c6
Compare
- Improve from message_ix_models.project.engage. - Reference .model.Config.relation_global_co2 via Context, instead of hard-coded RELATION_GLOBAL_CO2.
- Improve from message_ix_models.project.engage. - Reference .model.Config.relation_global_co2 via Context, instead of hard-coded RELATION_GLOBAL_CO2.
Prompted by this issue (Slack link, non-public), this PR migrates two functions used in .transport.workflow.tax_emission():
…along with the code on which these are dependent.
The files and Git history migrate from the message_data
dev
branch, which is the version that is currently used / known-to-work with message_ix_models.model.transport. Some of these files may have been changed on the message_datassp_dev
branch; those changes can later be merged into their new locations here.Per our usual migration approach, the files were selected with the following:
and the following in replacements.txt:
Next:
.engage.workflow
migration #351.How to review
.engage.workflow
migration #351..engage.workflow
migration #351 is merged into this branch.PR checklist