You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ASIDE: Are /var/log/calibre-web.log blank lines on 962 and 1001 something we should clean up? (Or is that an upstream Calibre-Web issue we should not get involved with for now?)
Backward compatibility, ensuring playlists download without an itch.
ASIDE: Are /var/log/calibre-web.log blank lines on 962 and 1001 something we should clean up? (Or is that an upstream Calibre-Web issue we should not get involved with for now?)
Not very important, but we'll keep an eye to it so someday we can look into it.
Motivations behind PR #99 are not (yet!) clear to me and @EMG70:
If it's blocking testing or other PR's (not great, but Ok!) then please prioritize helping everyone in understanding PR #99's motivations, Thank You! 💯
PR #99 appears to contain serious problems based on a misunderstanding as to where we are headed:
So hopefully merging this PR #96 can serve as a basis for reworking PR #99 — moving us all (baby steps! one step at a time!) — towards what's actually needs... 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request Overview:
This pull request includes the following enhancements to the download task:
These changes aim to make the download process more robust and provide users with better information about download failures.
📋 Checklist:
🔗 Related Issues:
Issue #89
📌 Testing scenarios:
See Issue #97
cc @EMG70