Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix imprecise Result path #5

Merged
merged 1 commit into from
Feb 27, 2021

Conversation

pierzchalski
Copy link
Contributor

It's a common pattern in large crates to define a custom Error type, then define an alias type Result<T> = std::result::Result<T, Error>. Unfortunately, this proc macro referred to Result, not ::std::result::Result, so it would resolve to the custom type.

@ihrwein
Copy link
Owner

ihrwein commented Feb 27, 2021

It took me a while to respond to this, but thank you.

@ihrwein ihrwein merged commit 16eced0 into ihrwein:master Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants