Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the data category 'ihm_ordered_ensemble' is misleading #88

Open
jaredsagendorf opened this issue Jul 27, 2023 · 0 comments
Open

the data category 'ihm_ordered_ensemble' is misleading #88

jaredsagendorf opened this issue Jul 27, 2023 · 0 comments

Comments

@jaredsagendorf
Copy link

jaredsagendorf commented Jul 27, 2023

The data category ihm_ordered_ensemble is a bit misleading and inaccurate for two reasons:

  1. It is not actually an ensemble, but just a directed graph of model groups, none of which need be ensembles themselves.
  2. The directed graph need not actually define a strict ordering - it can define a cycle or a tree (i.e. branched process).

A suggested fix would be to re-name the category ihm_partially_ordered_model_groups. That seems descriptive enough, and should cover all cases which the current dictionary can be used to represent. The term "partially ordered" comes from the concept of partially ordered sets in mathematics: https://en.wikipedia.org/wiki/Partially_ordered_set

It may also be useful to add an optional descriptive category data item to explicitly identify if the model groups represent a strict ordering, a cycle or a branched process. This is of course implicit in the edges, but not obvious without tracing out the whole graph.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant