Adjust vertical positioning of header and body text in dialog panels#9886
Adjust vertical positioning of header and body text in dialog panels#9886onurcanyasar wants to merge 1 commit intoihhub:masterfrom
Conversation
…panel Added `headerBodySpacing` constant and adjusted the Y position of the body text. Also slightly modified the header Y position for better vertical alignment.
|
Would you mind reviewing this PR when you have a chance? Thanks! @ihhub |
|
Hi @LeHerosInconnu, can you check the changes for windows with and without text? |
|
Hello @ihhub and @onurcanyasar,
The vertical position of the yellow title text in relation to the top of the window is fine. For the space between the bottom of the text and the bottom of the window, it is also necessary to take into account any graphic defects in the window decorations that may appear when the vertical size of the window is increased. Also, the space between the yellow title and the white text should correspond to the space of an empty line of text (as if a line had been passed between the yellow title and the white text), i.e. 34 pixels between the baseline of the letters of three lines of text. |








Fix #1260
This PR introduces a new constant headerBodySpacing and adjusts the Y positions of the header and body text elements in dialog panels. The changes improve vertical alignment and better reflect the original game’s layout, where the space below the text is slightly larger than the space above.
These updates aim to resolve the visual imbalance noted in issue #1260, where the body text appeared too close to the header and the top of the text was too far from the window’s upper edge.