Fix multiple spellbook-related issues in the Battle Only mode #8160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-derevenetz
added
bug
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Districh-ru
approved these changes
Dec 23, 2023
ihhub
approved these changes
Dec 24, 2023
|
@oleg-derevenetz , thanks a lot for this fix! |
Kazhuu
pushed a commit
to Kazhuu/fheroes2
that referenced
this pull request
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in the
masterbranch:fheroes2.engine.version_.1.0.10.2023-12-22.19-12-03.mp4
With this PR:
fheroes2.engine.version_.1.0.10.2023-12-22.19-15-48.mp4
Another problem that this PR is intended to fix is that when removing the spell book through the UI, the list of spells that the hero knows has not actually been cleared. Also in the
masterbranch, for the purposes of evaluating heroes and their armies by the AI, spells from scrolls were taken into account even if the hero did not have a spell book (and he could not actually use these scrolls).