Allow different translations of "Red Tower" #5040
Conversation
|
Not updating translation files yet to avoid conflicts, before this is merged: #4971 |
oleg-derevenetz
added
improvement
|
Hi @a1exsh , you can update now. |
Both Sorceress and Warlock have a building named "Red Tower". In some translations, e.g. Russian "Buka" version, they are translated differently, which makes it a bit nicer. In order to support the same, we have to use distinct translatable strings.
a1exsh
force-pushed
the
red-tower-distinct
branch
from
326465e to
b506ef5
Compare
|
@ihhub updated, please check. An example distinct translation is provided for |
|
Hi @zenseii , @Arthusppp, @LeHerosInconnu and @shprotru , could you please help with translations for other languages? |
| @@ -2063,7 +2063,8 @@ msgstr "Oppg. steinring" | |||
| msgid "Fenced Meadow" | |||
| msgstr "Inngjerdet slette" | |||
|
|
|||
| msgid "Red Tower" | |||
| #, fuzzy | |||
| msgid "sorceress|Red Tower" | |||
| msgstr "Rødt tårn" | |||
There was a problem hiding this comment.
| msgstr "Rødt tårn" | |
| msgstr "Ildtårn" |
| @@ -528,7 +528,7 @@ namespace | |||
| case DWELLING_MONSTER5: | |||
| return _( "Fenced Meadow" ); | |||
| case DWELLING_MONSTER6: | |||
| return _( "Red Tower" ); | |||
| return _( "sorceress|Red Tower" ); | |||
There was a problem hiding this comment.
Do we want to change this in English as well then? For me I don't mind either leaving it as is or changing it.
There was a problem hiding this comment.
Here are some suggestions for names in any case:
Crimson Tower
Fiery Tower
One less obvious reason to keep the original is that we won't waste good names when we strictly don't need to. Most players don't mind the duplicate names afaik.
Allow different translations of "Red Tower" ihhub#5040
|
Hello @a1exsh, @ihhub and @zenseii,
I do not find it disturbing that buildings have the same name if they are not located in the same castle, especially since there is only one case.
|
Agree, in Polish, we have the "same situation". Nevertheless, I totally understand that in different languages it can be a different situation. Therefore, I have translated both "Red Towers" using the same name. :) |
|
@a1exsh , thank you for these changes! I merged this pull request to proceed further with translations since the author of this PR is busy at the moment. |
Both Sorceress and Warlock have a building named "Red Tower". In some
translations, e.g. Russian "Buka" version, they are translated differently,
which makes it a bit nicer.
In order to support the same we have to use distinct translatable strings.