More dialogs to exit with READY hotkey

[a1exsh]

Hero, Castle and Kingdom dialogs have only one button: EXIT. Especially
when playing with one hand holding the mouse (to the right of the keyboard) it
is more convenient to exit these screens by hitting the num-pad ENTER.

Otherwise one has to either use the mouse to click on the button or use one's
left hand to hit ESC.

[a1exsh]

Also found and updated these dialogs:

• Battle options
• Adventure options
• File options
• Army info
• View world
• Spell book

[ihhub]

Hi @a1exsh , let's think from consistency point of view: if a dialog contains OKAY button then using Enter makes sense as this key is used as a confirmation. When a dialog contains EXIT button Esc (Escape --> exit) is more appropriate. So I might suggest to stick to this logic rather than trying to adopt to everyone's style. What do you think?

I'd like to hear @Branikolog and @ LeHerosInconnu opinions as well.

[a1exsh]

For me personally, convenience is one of the major reasons to play fheroes2 — otherwise I'd just stick with the OG ;)

[ihhub]

For me personally, convenience is one of the major reasons to play fheroes2 — otherwise I'd just stick with the OG ;)

I absolutely agree but consistency is important as well. Imagine if an old player from HoMM2 comes and tries to use Esc button and realizes that it doesn't work :)

[a1exsh]

For me personally, convenience is one of the major reasons to play fheroes2 — otherwise I'd just stick with the OG ;)

I absolutely agree but consistency is important as well. Imagine if an old player from HoMM2 comes and tries to use Esc button and realizes that it doesn't work :)

Ah, about that you should not worry — the proposed change keeps ESC, but adds Enter: so using either of them amount to closing these dialogs.

[ihhub]

@a1exsh , thanks for this change! Now it became clearer to me :)

[Branikolog]

Hi, @ihhub & @a1exsh !
Plus-ultra enhancement! Really missed it. Thanks a lot!