Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace scrollbar in Experimental Settings dialog #4275

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

a1exsh
Copy link
Contributor

@a1exsh a1exsh commented Sep 28, 2021

Fix #1420

@a1exsh
Copy link
Contributor Author

a1exsh commented Sep 28, 2021

Screenshot from 2021-09-28 09-15-07

@LeHerosInconnu
Copy link

LeHerosInconnu commented Sep 28, 2021

Hello @a1exsh,

Nice, I prefer this way. :)
Could the top of the scrollbar be aligned with the top of the first checkbox and the bottom of the scrollbar aligned with the bottom of the last checkbox?
For a perfect position of the scrollbar, we should also move the scrollbar 1 pixel to the left to have the same distance between, the left edge of the checkbox and the left edge of the window, and the right edge of the scrollbar and the right edge of the window. :)

@shprotru
Copy link
Contributor

Hi, @LeHerosInconnu! Aligning to the bottom of the last checkbox is strange, because people always expect smooth scrolling, while this condition will bring ragged scrolling.

@LeHerosInconnu
Copy link

Hello @shprotru,

Hi, @LeHerosInconnu! Aligning to the bottom of the last checkbox is strange, because people always expect smooth scrolling, while this condition will bring ragged scrolling.

Okay, the best possible has to be done. :)

@ihhub ihhub added improvement New feature, request or improvement ui UI/GUI related stuff labels Sep 28, 2021
@ihhub ihhub added this to the 0.9.8 milestone Sep 28, 2021
@ihhub ihhub merged commit 485e4de into ihhub:master Sep 28, 2021
@ihhub
Copy link
Owner

ihhub commented Sep 28, 2021

@a1exsh , thanks a lot for this fix!

@a1exsh
Copy link
Contributor Author

a1exsh commented Sep 29, 2021

@LeHerosInconnu we could also drop the shadow from the scrollbar, to make it look even closer to the original. Too late to do that in this PR, but maybe sometime later. ;)

@a1exsh a1exsh deleted the replace-ext-settings-scrollbar branch September 29, 2021 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature, request or improvement ui UI/GUI related stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Game Settings window, scroll bar graphic border
4 participants