audio_music: log the reason why mixer could not be created #4168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On NixOS SDL2_mixer was not configured fully against timidity,
but it was not immediately clear:
10:02:38: [ERROR] PlayMusic: music parameter was NULL
With the patch error reporting is more straightforward:
10:03:45: [ERROR] Play: Couldn't open /etc/timidity/freepats.cfg
The change makes error handling in
void Music::Play( const std::vector<uint8_t> & v, const bool loop )
void Music::Play( const std::string & file, const bool loop )
identical.
oleg-derevenetz
added
improvement
ihhub
requested changes
Sep 5, 2021
|
@trofi , thank you so much for your contribution to the project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On NixOS SDL2_mixer was not configured fully against timidity,
but it was not immediately clear:
10:02:38: [ERROR] PlayMusic: music parameter was NULL
With the patch error reporting is more straightforward:
10:03:45: [ERROR] Play: Couldn't open /etc/timidity/freepats.cfg
The change makes error handling in
void Music::Play( const std::vector<uint8_t> & v, const bool loop )
void Music::Play( const std::string & file, const bool loop )
identical.