Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Battle Only mode #2505

Merged
merged 1 commit into from
Dec 28, 2020
Merged

Fix Battle Only mode #2505

merged 1 commit into from
Dec 28, 2020

Conversation

ihhub
Copy link
Owner

@ihhub ihhub commented Dec 28, 2020

relates to #2122
and also some code cleanup

relates to #2122
and also some code cleanup
@ihhub ihhub added logic Things related to game logic regression Something went wrong in previous commits labels Dec 28, 2020
@ihhub ihhub added this to the 0.9 milestone Dec 28, 2020
@ihhub ihhub self-assigned this Dec 28, 2020
@ihhub
Copy link
Owner Author

ihhub commented Dec 28, 2020

Hi @eos428 , this is what we missed last time :)

@eos428
Copy link
Contributor

eos428 commented Dec 28, 2020

Hi @eos428 , this is what we missed last time :)

Hi. Do you mean that we missed this particular game type for saves?

@ihhub
Copy link
Owner Author

ihhub commented Dec 28, 2020

Hi @eos428 , this is what we missed last time :)

Hi. Do you mean that we missed this particular game type for saves?

Battle mode is not test mode and since we changes the type the player couldn't use it anymore.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_151) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 11.
Read more here

@ihhub ihhub merged commit 45a5938 into master Dec 28, 2020
@ihhub ihhub deleted the battle_only branch December 28, 2020 15:34
vincent-grosbois pushed a commit to vincent-grosbois/fheroes2 that referenced this pull request Dec 28, 2020
relates to ihhub#2122
and also some code cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logic Things related to game logic regression Something went wrong in previous commits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants