-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Introduce Scalafix and Lint / Refactor the code #463
Refactor: Introduce Scalafix and Lint / Refactor the code #463
Conversation
You can run scalafmt with the following command. sbt scalafixAll scalafmtAll |
427db4a
to
82f00a0
Compare
Hi @Javakky-pxv, thanks so much for your contributions. Will you be interested in becoming a maintainer of play-swagger? I myself have stopped using the play framework for years so I've been neglecting it. It will be really nice to have a maintainer who is invested in the project like you do. Please let me know. |
@kailuowang Thank you. Here is what I am thinking right now. What I want to do :
What I am worried about:
|
Once again, this proposal is very attractive to me. By all means, let me continue to cooperate with you! |
@Javakky-pxv that's awesome!!! I'm very excited to welcome you. As for the other things on your "I want to do" list, you are more than welcome to do whatever you think is good for the project and community. (Other contributors are welcome to do that as well) I will remain a maintainer to help reviews, particularly your PR upon your request. I am sending you an invite to the project soon. |
@kailuowang |
82f00a0
to
4cb7b19
Compare
Look after this because of the dependencies of the pr: #462
scalafix is a Linter and refactoring tool designed for Scala.
It can automatically respond to compiler warnings by introducing some useful settings such as import alignment.
The rules described here only work with Scala 2.12 series, but you can use them for various code conditions if you try hard enough. (e.g. The rules I have: https://github.com/pixiv/scalafix-pixiv-rule)
Although this tool is slower than scalafmt, we ask that you consider it, as its introduction would improve the development experience 🙇