Fixing NCCH flag detection code for zerokey #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Encrypted CCIs no longer work with 3dsconv.py. All xorpads are incorrectly displayed as corrupt or a mismatch. Analysis: The recently-committed code that checked the NCCH flags for zerokey encryption was calling read(1) twice for each flag comparison, which resulted in the wrong byte being used for comparison in the second case. As a result, all encrypted CCIs are incorrectly flagged as being encrypted with a fixed/zero key. This commit stores the bitmask in a temporary variable instead. Encrypted CCIs are now properly detected and packed as expected.
|
yeah, someone told me conversion was broken for encrypted roms a few days ago, wasn't sure what was causing it (even though the output says "zerokey" but I never checked that :c). thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Encrypted CCIs no longer work with 3dsconv.py. All xorpads are incorrectly displayed as corrupt or a mismatch.
Analysis:
The recently-committed code that checked the NCCH flags for zerokey encryption was calling read(1) once for each flag comparison, which resulted in the wrong byte being used for comparison in the second case. As a result, all encrypted CCIs are incorrectly flagged as being encrypted with a fixed/zero key.
This commit stores the bitmask in a temporary variable instead. Encrypted CCIs are now properly detected and packed as expected.