Move mprec_*tens arrays to PROGMEM #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are several double[] arrays in mprec.c which can be moved to progmem without any performance impact or code changes (doubles are 8-bytes, so all accesses and alignments should be on 32-bit or even 64-bit boundaries). strtod() also has the same (duplicated) tinytens array, also moved. Saves about 280 bytes of RAM where these arrays appear.
|
Looks good as well, just the header file thing mentioned in #4. |
|
Closing in lieu of #5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is related to esp8266/Arduino#3740 , increasing heap RAM on the ESP8266 by moving library constants into ROM.
There are several double[] arrays in mprec.c which can be moved to progmem
without any performance impact or code changes (doubles are 8-bytes, so
all accesses and alignments should be on 32-bit or even 64-bit boundaries).
strtod() also has the same (duplicated) tinytens array.
Saves about 280 bytes of RAM where these arrays appear.