Merge branch 'dvisockas-master'

igrigorik · Nov 24, 2015 · 4811a51 · 4811a51
2 parents 15394f8 + 823dd5e
commit 4811a51
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/examples/continuous-id3.rb b/examples/continuous-id3.rb
@@ -6,6 +6,8 @@
 
 # Read in the training data
 training = []
+attributes = nil
+
 File.open('data/continuous-training.txt', 'r').each_line do |line|
   data = line.strip.chomp('.').split(',')
   attributes ||= data

diff --git a/examples/discrete-id3.rb b/examples/discrete-id3.rb
@@ -5,6 +5,8 @@
 
 # Read in the training data
 training = []
+attributes = nil
+
 File.open('data/discrete-training.txt', 'r').each_line do |line|
   data = line.strip.split(',')
   attributes ||= data
@@ -45,7 +47,7 @@
       v
     end
   end
-  training.push(test_data)
+  test.push(test_data)
 end
 
 # Let the tree predict the output and compare it to the true specified value

diff --git a/lib/decisiontree/id3_tree.rb b/lib/decisiontree/id3_tree.rb
@@ -190,7 +190,7 @@ def build_tree(tree = @tree)
         end
         label_text = "#{key} ''"
         if type(attr[0].attribute) == :continuous
-          label_text.gsub!("''", attr[0].threshold)
+          label_text.gsub!("''", attr[0].threshold.to_s)
         end
 
         [parent_text, child_text, label_text]