Skip to content

Conversation

@thomasp85
Copy link

Fixes #34

In order to avoid conversion of factors attribute elements are
initialised prior to assignment if the attribute does not exist or if
the assignment is overwriting all elements within that attribute

In order to avoid conversion of factors attribute elements are
initialised prior to assignment if the attribute does not exist or if
the assignment is overwriting all elements within that attribute
@thomasp85
Copy link
Author

FWIW, the failed build has nothing to do with this PR...

Copy link

@IgnatiusPang IgnatiusPang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The codes look ok to me.

@mathlandry
Copy link

Are these changes present in the R igraph package? In my case, set_vertex_attr() and vertex_attr()<- both still convert factors to integers

@vtraag
Copy link
Member

vtraag commented Mar 30, 2021

@mathlandry , no this code is not yet merged. This is a Pull Request with new proposed code that should still be integrated in the main codebase. After it will be merged, you can install it using remotes::install_github("igraph/rigraph@master"). I will try to do this shortly.

@krlmlr
Copy link
Contributor

krlmlr commented Apr 9, 2024

Thank you for your contribution. This has conflicts now and needs to be redone. The original issue #34 has a reprex and points to this PR.

@krlmlr krlmlr closed this Apr 9, 2024
@aviator-app
Copy link
Contributor

aviator-app bot commented Apr 9, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was closed without merging. If you still want to merge this PR, re-open it.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

R: graph.data.frame converts factors to character

5 participants