-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make libxml optional #1282
Conversation
Current Aviator status
This PR was merged using Aviator.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can you please update the SystemRequirements
section in DESCRIPTION
too, also for GLPK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If libxml2 detection fails at either of the three steps, could we print a message saying something like "GraphML import will not be available." ?
Also, it would be good if someone could test this on a system where libxml2 is not available: make sure it compiles, links, and trying to import a GraphML file gives a nice error. I don't see any reason why it wouldn't work, but just in case ... it's hard for me to hide libxml2 since it comes as standard on macOS. |
I have tried to delete libxml2 on my local virtual env. It compiles and links. Didn't try to import file, but I will do. |
Co-authored-by: Szabolcs Horvát <szhorvat@gmail.com>
Co-authored-by: Szabolcs Horvát <szhorvat@gmail.com>
Co-authored-by: Szabolcs Horvát <szhorvat@gmail.com>
9393685
to
ffabf14
Compare
Closes #1217