Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make libxml optional #1282

Merged
merged 7 commits into from
Mar 6, 2024
Merged

chore: make libxml optional #1282

merged 7 commits into from
Mar 6, 2024

Conversation

Antonov548
Copy link
Contributor

@Antonov548 Antonov548 commented Mar 5, 2024

Closes #1217

Copy link
Contributor

aviator-app bot commented Mar 5, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

Copy link
Contributor

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you please update the SystemRequirements section in DESCRIPTION too, also for GLPK?

Copy link
Member

@szhorvat szhorvat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If libxml2 detection fails at either of the three steps, could we print a message saying something like "GraphML import will not be available." ?

configure Outdated Show resolved Hide resolved
configure Outdated Show resolved Hide resolved
configure Outdated Show resolved Hide resolved
@szhorvat
Copy link
Member

szhorvat commented Mar 5, 2024

Also, it would be good if someone could test this on a system where libxml2 is not available: make sure it compiles, links, and trying to import a GraphML file gives a nice error. I don't see any reason why it wouldn't work, but just in case ... it's hard for me to hide libxml2 since it comes as standard on macOS.

@Antonov548
Copy link
Contributor Author

Also, it would be good if someone could test this on a system where libxml2 is not available: make sure it compiles, links, and trying to import a GraphML file gives a nice error. I don't see any reason why it wouldn't work, but just in case ... it's hard for me to hide libxml2 since it comes as standard on macOS.

I have tried to delete libxml2 on my local virtual env. It compiles and links.

Didn't try to import file, but I will do.

Antonov548 and others added 7 commits March 6, 2024 04:52
Co-authored-by: Szabolcs Horvát <szhorvat@gmail.com>
Co-authored-by: Szabolcs Horvát <szhorvat@gmail.com>
Co-authored-by: Szabolcs Horvát <szhorvat@gmail.com>
@aviator-app aviator-app bot merged commit 5c730b0 into main Mar 6, 2024
14 checks passed
@aviator-app aviator-app bot deleted the libxml-optional branch March 6, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve libxml2 detection
3 participants