fix: Fix rglplot(edge_label = )
#1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Aviator status
This PR was merged using Aviator.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
maelle
commented
Feb 27, 2024
| @@ -65,3 +65,14 @@ test_that("basic plot test, spheres", { | |||
| } | |||
| ) | |||
| }) | |||
|
|
|||
| test_that("rgplot() works", { | |||
| withr::local_envvar(RGL_USE_NULL = TRUE) | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Should this be a comment in the code instead? Only what's in the code will remain visible later.
krlmlr
reviewed
Mar 2, 2024
krlmlr
changed the title
rglplot(edge_label = )
|
Thanks! |
aviator-app
bot
force-pushed
the
rglplot-bug
branch
from
0f152be
to
72ecb90
Compare
aviator-app
bot
force-pushed
the
rglplot-bug
branch
from
72ecb90
to
cfe7eba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #25
I do not understand the code, but this apparently fixes the bug and follows the pattern of the previous code lines. 😇