Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that scalars are scalars during conversion #1141

Closed
maelle opened this issue Jan 22, 2024 · 3 comments
Closed

Check that scalars are scalars during conversion #1141

maelle opened this issue Jan 22, 2024 · 3 comments
Labels

Comments

@maelle
Copy link
Contributor

maelle commented Jan 22, 2024

(i.e. do not try to index into a zero-length vector with REAL(vec)[0]) — waiting on #1068

@szhorvat
Copy link
Member

This was done in tandem with bounds checking for scalar. Same comments apply as in #1140 (comment)

Auto-generated part was done in #1051, manually written code still needs checks using R_check_int_scalar(), R_check_real_scalar(), R_check_bool_scalar()

@maelle
Copy link
Contributor Author

maelle commented Jan 22, 2024

Ok, then I'll check the box in #840 and close this. Thank you!

@maelle maelle closed this as completed Jan 22, 2024
@szhorvat
Copy link
Member

It wouldn't be a bad idea to keep at least one issue open for including checks in all manually written functions. Of course we want to auto-generate as much as possible, but I don't see this getting to 100%.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants