Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for overflow and NaN when doing double -> igraph_integer_t conversion. #1140

Open
maelle opened this issue Jan 22, 2024 · 2 comments
Open

Check for overflow and NaN when doing double -> igraph_integer_t conversion. #1140

maelle opened this issue Jan 22, 2024 · 2 comments
Assignees
@Antonov548
Labels
upkeep maintenance, infrastructure, and similar
Milestone
upgrade-2

Comments

@maelle
Copy link
Contributor

maelle commented Jan 22, 2024 •
edited by krlmlr
Loading

From #840.
@szhorvat
Copy link
Member

szhorvat commented Jan 22, 2024 •
edited
Loading

This is done for the auto-generated part, see #1051 and R_check_int_scalar().

It still needs to be done for the manually written functions, but that does not involve Stimulus. A few manually written functions were done in #1069. PR #1068 (not yet merged) makes a further improvement.

@szhorvat szhorvat mentioned this issue Jan 22, 2024
Closed
@maelle maelle removed the stimulus label Jan 22, 2024
@maelle maelle mentioned this issue Jan 22, 2024
Merged
@maelle maelle added the upkeep maintenance, infrastructure, and similar label Jan 22, 2024
@krlmlr
Copy link
Contributor

krlmlr commented Jan 23, 2024

From #1071.

@maelle maelle added this to the upgrade-2 milestone Jan 29, 2024
@szhorvat szhorvat mentioned this issue Jul 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Antonov548 Antonov548

Labels
upkeep maintenance, infrastructure, and similar
Projects
None yet
Milestone
upgrade-2
Development

No branches or pull requests
4 participants
@szhorvat @krlmlr @maelle @Antonov548