fix: delete terminal buffer on disconnect #110
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: If the debug adapter doesn't have supportsTerminateRequest capability (e.g., OpenDebugAD7 from cpptools), terminating the debuggy doesn't fire "terminated" event. So the terminal buffer for debuggy is not deleted by dap-view's event handler, and remains pooled by nvim-dap. A subsequent session reuses this terminal buffer, which is not expected by dap-view's terminal lifecycle management. As a result the user ends up seeing empty buffer created by dap-view, while the actual terminal buffer is hidden. Solution: Reuse the cleanup logic of the "terminated"-handler on "disconnect"-handler.
Owner
|
Hello, Have you seen #108? It aims to let nvim-dap handle the terminal buffer lifecycle on its own. I'm not sure if it would fix this specific issue, but any fixes should go to that branch |
Contributor
Author
|
The problem seems to be fixed by #108. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
If the debug adapter doesn't have supportsTerminateRequest capability (e.g., OpenDebugAD7 from cpptools), terminating the debuggy doesn't fire "terminated" event. So the terminal buffer for debuggy is not deleted by dap-view's event handler, and remains pooled by nvim-dap. A subsequent session reuses this terminal buffer, which is not expected by dap-view's terminal lifecycle management. As a result the user ends up seeing empty buffer created by dap-view, while the actual terminal buffer is hidden.
Solution:
Reuse the cleanup logic of the "terminated"-handler on "disconnect"-handler.