Update find_signed to find_signed! for Rails 6.1 #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`find_signed` no longer works in Rails 6.1, but `find_signed!` does. So we add a version check and use a different method depending on the Rails version.
connorshea
added a commit
to connorshea/vglist
that referenced
this pull request
Dec 13, 2020
|
thank you, all looks good to me, I see this change here: https://github.com/rails/rails/blob/8ef5bd9ced351162b673904a0b77c7034ca2bc20/activestorage/app/models/active_storage/blob.rb#L77 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find_signedno longer works in Rails 6.1, butfind_signed!does.So we add a version check and use a different method depending on the Rails version.
I tested this in my application vglist and it fixes the error, although I'm not sure how it should have an automated test written for it.
Fixes #93.
I'm sure there's a better way to determine the Rails version here, but I couldn't think of anything else that would work for, e.g. Rails 6.2, Rails 7, etc.