Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Denote Openfire 4.0.0 Release #505

Merged
merged 1 commit into from
Jan 11, 2016
Merged

Denote Openfire 4.0.0 Release #505

merged 1 commit into from
Jan 11, 2016

Conversation

akrherz
Copy link
Member

@akrherz akrherz commented Jan 8, 2016

This assumes pull requests #486 , #503, #504 are approved and merged first.

@tevans
Copy link
Member

tevans commented Jan 8, 2016

👍

@guusdk
Copy link
Member

guusdk commented Jan 11, 2016

+1

On a side-note: Perhaps we should rethink our issue logging / code modification strategy. Currently, we keep issues in JIRA (from which the changelog is generated). Since we moved from SVN to Github, more and more pull requests got accepted that don't relate to any JIRA issue. That causes us to miss changes in the release notes.

I'm not advocating for any particular change. I don't dislike JIRA, I don't dislike Github, and I certainly don't want to enforce "paperwork" - however as things are now, we're presenting a changelog as if it were a complete overview, while it isn't.

@sco0ter
Copy link
Contributor

sco0ter commented Jan 11, 2016

On the other side, there are issues, which should not appear in the changelog, because they only reflect issues, which have occurred during work on 4.0.0, but not with any previous release. It will clutter the changelog and confuse users (e.g. if there are 3-4 bugs for XEP-0198, which is actually a new feature).

Some of theses issues are (among others): OF-1002, OF-1003, OF-1005, OF-1009, OF-1025, OF-1028, OF-1036.

IIRC, most PRs have an issue associated, unless they were either some internal code cleanup, refactoring or rework of other unreleased work.

@akrherz
Copy link
Member Author

akrherz commented Jan 11, 2016

Okay, updated PR:

  1. Changed release date to today
  2. Removed OF-872 from changelog

dwd added a commit that referenced this pull request Jan 11, 2016
Denote Openfire 4.0.0 Release
@dwd dwd merged commit 7c5b4d7 into igniterealtime:master Jan 11, 2016
@sco0ter
Copy link
Contributor

sco0ter commented Jan 11, 2016

I am still in favor of removing these other issues as well, which refer to "work-in-progress" of 4.0.0-only work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants