Skip to content

Conversation

@lumtis
Copy link
Contributor

@lumtis lumtis commented Mar 12, 2021

Use uint64 for the type of id for auto-incremented types.

Store them with big-endian encoding so that the types are in increasing order when listing them.

Prevent querying a type that doesn't exist.

@lumtis lumtis requested review from fadeev and ilgooz as code owners March 12, 2021 09:30
@lumtis lumtis requested a review from clockworkgr March 12, 2021 09:30
@lumtis lumtis linked an issue Mar 12, 2021 that may be closed by this pull request
@lumtis lumtis marked this pull request as draft March 12, 2021 09:46
@lumtis lumtis marked this pull request as ready for review March 12, 2021 10:28
Copy link
Contributor

@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ilgooz ilgooz merged commit e2e3502 into develop Mar 12, 2021
@ilgooz ilgooz deleted the refactor/id-uint64 branch March 12, 2021 13:02
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
…ndian (ignite#848)

* Change id to uint64

* Fixes

* Fixes

* Refactor for legacy

* Fix legacy

* Last fixes

* Fix sprintf

* starport/templates/typed/stargate_legacy/x/{{moduleName}}/handler_{{typeName}}.go.plush
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Store types (with autoincrement ID) using big endian for ordering

4 participants