Skip to content

feat: add support for using external node on faucet #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2021
Merged

feat: add support for using external node on faucet #813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions starport/pkg/chaincmd/chaincmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import (

"github.com/tendermint/starport/starport/pkg/cmdrunner/step"
"github.com/tendermint/starport/starport/pkg/cosmosver"
"github.com/tendermint/starport/starport/pkg/xurl"
)

const (
Expand Down Expand Up @@ -145,7 +144,7 @@ func WithKeyringPassword(password string) Option {
// API request to the node that has a different node address other than the default one.
func WithNodeAddress(addr string) Option {
return func(c *ChainCmd) {
c.nodeAddress = xurl.TCP(addr)
c.nodeAddress = addr
}
}

Expand Down Expand Up @@ -461,6 +460,7 @@ func (c ChainCmd) QueryTxEventsCommand(query string) step.Option {
)
}

command = c.attachNode(command)
return c.cliCommand(command)
}

Expand Down Expand Up @@ -488,6 +488,7 @@ func (c ChainCmd) StatusCommand() step.Option {
commandStatus,
}

command = c.attachNode(command)
return c.cliCommand(command)
}

Expand Down Expand Up @@ -515,7 +516,7 @@ func (c ChainCmd) attachHome(command []string) []string {
return command
}

// attacNode appends the node flag to the provided command
// attachNode appends the node flag to the provided command
func (c ChainCmd) attachNode(command []string) []string {
if c.nodeAddress != "" {
command = append(command, []string{optionNode, c.nodeAddress}...)
Expand Down
4 changes: 3 additions & 1 deletion starport/services/chain/chain.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,12 @@ import (

"github.com/go-git/go-git/v5"
"github.com/gookit/color"

conf "github.com/tendermint/starport/starport/chainconf"
"github.com/tendermint/starport/starport/pkg/chaincmd"
chaincmdrunner "github.com/tendermint/starport/starport/pkg/chaincmd/runner"
"github.com/tendermint/starport/starport/pkg/cosmosver"
"github.com/tendermint/starport/starport/pkg/xurl"
)

var (
Expand Down Expand Up @@ -421,7 +423,7 @@ func (c *Chain) Commands(ctx context.Context) (chaincmdrunner.Runner, error) {
chaincmd.WithChainID(id),
chaincmd.WithHome(home),
chaincmd.WithVersion(c.Version),
chaincmd.WithNodeAddress(config.Servers.RPCAddr),
chaincmd.WithNodeAddress(xurl.TCP(config.Servers.RPCAddr)),
}

if c.plugin.Version() == cosmosver.Launchpad {
Expand Down