Skip to content

refactor(scaffolding): switch from packr to embed #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 3, 2021
Merged

refactor(scaffolding): switch from packr to embed #805

merged 3 commits into from
Mar 3, 2021

Conversation

@ilgooz
Copy link
Member

@ilgooz ilgooz commented Mar 2, 2021

for embedding scaffolding templates into Starport's binary.

solves a part of #756.

@ilgooz ilgooz requested review from fadeev and lumtis as code owners March 2, 2021 14:48
@ilgooz ilgooz marked this pull request as draft March 2, 2021 14:48
@ilgooz ilgooz force-pushed the refactor/genny branch 7 times, most recently from 5d733a1 to 47b0c99 Compare March 2, 2021 18:05
@ilgooz
refactor(scaffolding): switch from packr to embed
e185922 
for embedding scaffolding templates into Starport's binary.
@ilgooz ilgooz marked this pull request as ready for review March 2, 2021 18:19
lumtis
lumtis previously approved these changes Mar 3, 2021
View reviewed changes
@fadeev
Copy link
Contributor

fadeev commented Mar 3, 2021

After I build starport with make, delete starport dir (to check that it's not getting static files from the source) and try to scaffold, I get an error:

fadeev@system tendermint % starport app github.com/hello/world

go: cannot use path@version syntax in GOPATH mode
: exit status 1

@ilgooz
Copy link
Member Author

ilgooz commented Mar 3, 2021

@fadeev what directory you're deleting exactly?

@fadeev
Copy link
Contributor

fadeev commented Mar 3, 2021

I deleted directory with the source code of Starport.

@ilgooz ilgooz requested a review from lumtis March 3, 2021 07:37
fadeev
fadeev approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works both locally and on Gitpod! 👍

faddat
faddat approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@faddat faddat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:).

When I looked into this I had the same thought when using Genny-- hey this is made for boxes!

Nice xgenny 👍

@ilgooz ilgooz merged commit 1f2f47c into develop Mar 3, 2021
@ilgooz ilgooz deleted the refactor/genny branch March 3, 2021 13:08
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@ilgooz
refactor(scaffolding): switch from packr to embed (ignite#805)
d89fd72 
* refactor(scaffolding): switch from packr to embed

for embedding scaffolding templates into Starport's binary.

* fix gitpod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lumtis lumtis Awaiting requested review from lumtis

2 more reviewers

@fadeev fadeev fadeev approved these changes

@faddat faddat faddat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ilgooz @fadeev @lumtis @faddat