Skip to content

feat(packet): scaffold an acknowledgment type for each new packet #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 2, 2021
Merged

feat(packet): scaffold an acknowledgment type for each new packet #800

merged 4 commits into from
Mar 2, 2021

Conversation

@lumtis
Copy link
Contributor

@lumtis lumtis commented Mar 1, 2021

No description provided.

@lumtis lumtis requested review from fadeev and ilgooz as code owners March 1, 2021 11:29
@lumtis lumtis linked an issue Mar 1, 2021 that may be closed by this pull request
IBC scaffold: create a type for the acknowledgment #798
Closed
fadeev
fadeev approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Do acks appear only in proto files or should they also be used somewhere in the module's code?

@lumtis
Copy link
Contributor Author

lumtis commented Mar 1, 2021

Do acks appear only in proto files or should they also be used somewhere in the module's code?

What do you mean? There is some code that has been added in the module template as well even though we never read the fields there

@lumtis lumtis requested a review from toschdev March 2, 2021 08:05
@lumtis lumtis merged commit 9cc965c into develop Mar 2, 2021
@lumtis lumtis deleted the feat/ack-type branch March 2, 2021 09:40
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@lumtis
feat(packet): scaffold an acknowledgment type for each new packet (ig…
86a8e5d 
…nite#800)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilgooz ilgooz ilgooz approved these changes

@toschdev toschdev Awaiting requested review from toschdev

+1 more reviewer

@fadeev fadeev fadeev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

IBC scaffold: create a type for the acknowledgment

4 participants

@lumtis @fadeev @ilgooz