Skip to content

fix(serve): default home deleted when starting app with custom home #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2021
Merged

fix(serve): default home deleted when starting app with custom home #778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4a6966
Fix CLI Home
lumtis Feb 22, 2021
0b312f6
Merge branch 'develop' into fix/home-delete
ilgooz Feb 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions starport/services/chain/chain.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,11 @@ func (c *Chain) DefaultHome() (string, error) {
// CLIHome returns the blockchain node's home dir.
// This directory is the same as home for Stargate, it is a separate directory for Launchpad
func (c *Chain) CLIHome() (string, error) {
// Return home dir for Stargate app
if c.SDKVersion().Is(cosmosver.Stargate) {
return c.Home()
}

// check if cli home is explicitly defined for the app
home := c.options.cliHomePath
if home == "" {
Expand Down
7 changes: 0 additions & 7 deletions starport/services/chain/plugin-launchpad.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,13 +115,6 @@ func (p *launchpadPlugin) Start(ctx context.Context, runner chaincmdrunner.Runne
return g.Wait()
}

func (p *launchpadPlugin) StoragePaths() []string {
return []string{
launchpadHome(p.app),
launchpadCLIHome(p.app),
}
}

func (p *launchpadPlugin) Home() string {
return launchpadHome(p.app)
}
Expand Down
6 changes: 0 additions & 6 deletions starport/services/chain/plugin-stargate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,6 @@ func (p *stargatePlugin) Start(ctx context.Context, runner chaincmdrunner.Runner
return &CannotStartAppError{p.app.Name, err}
}

func (p *stargatePlugin) StoragePaths() []string {
return []string{
p.Home(),
}
}

func (p *stargatePlugin) Home() string {
return stargateHome(p.app)
}
Expand Down
3 changes: 0 additions & 3 deletions starport/services/chain/plugin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@ type Plugin interface {
// StartCommands returns step.Exec configuration to start servers.
Start(context.Context, chaincmdrunner.Runner, starportconf.Config) error

// StoragePaths returns a list of where persistent data kept.
StoragePaths() []string

// Home returns the blockchain node's home dir.
Home() string

Expand Down