Skip to content

Conversation

@faddat
Copy link
Contributor

@faddat faddat commented Feb 9, 2021

This needed some alpine air; changed the image from arch to alpine. It should work identically.

This needed some alpine air; changed the image from arch to alpine.  It should work identically.
@faddat faddat changed the title Update Dockerfile fix: alpine-Dockerfile Feb 9, 2021
@faddat
Copy link
Contributor Author

faddat commented Feb 9, 2021

I am un-drafting this only to trigger the other checks.

Oh github actions is broken. Delight.

I mean github actions, the service, not any of our actions. I have been getting funny errors all night (500's for example).

@faddat faddat marked this pull request as ready for review February 9, 2021 16:27
add a comment and hopefully trigger actions
ilgooz
ilgooz previously approved these changes Feb 9, 2021
Copy link
Member

@ilgooz ilgooz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

install and use bash
@faddat
Copy link
Contributor Author

faddat commented Feb 9, 2021

This is ready to roll.

@faddat
Copy link
Contributor Author

faddat commented Feb 9, 2021

closes #741

Copy link
Member

@ilgooz ilgooz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks look green to me 😃

@ilgooz ilgooz merged commit 93550a0 into develop Feb 10, 2021
@ilgooz ilgooz deleted the docker-alpine branch February 10, 2021 06:45
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
* Update Dockerfile

This needed some alpine air; changed the image from arch to alpine.  It should work identically.

* Update Dockerfile

add a comment and hopefully trigger actions

* Update Dockerfile

* Update Dockerfile

install and use bash

* Update Dockerfile

protoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants