Skip to content

Conversation

@lumtis
Copy link
Contributor

@lumtis lumtis commented Feb 4, 2021

When adding types starport type .... it scaffolds transactions with the MsgServer convention:

service Msg {
  ...
}

type command includes a flag --legacy to use the old type generation without services creation.
This option is automatically used for old scaffolded code.

@lumtis lumtis linked an issue Feb 4, 2021 that may be closed by this pull request
@lumtis lumtis marked this pull request as ready for review February 4, 2021 16:15
@lumtis lumtis requested review from fadeev and ilgooz as code owners February 4, 2021 16:15
fadeev
fadeev previously approved these changes Feb 4, 2021
Copy link
Contributor

@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@ilgooz ilgooz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦖

@lumtis lumtis requested a review from fadeev February 5, 2021 06:55
@lumtis
Copy link
Contributor Author

lumtis commented Feb 5, 2021

@fadeev Added ID as result of CreateFoo since your last review

Copy link
Contributor

@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@lumtis lumtis merged commit 711dc5b into develop Feb 5, 2021
@lumtis lumtis deleted the feat/msg_server branch February 5, 2021 07:43
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scaffold services for transactions (MsgServer)

4 participants