feat: integrate with v0.52.x (1/n) - #4289
Conversation
github-actions
Bot
added
component:ci
julienrbrt
changed the title
|
Is it possible to keep this in a branch other than Not sure that shipping without IBC is such a great idea. |
It won't be shipped as final, but we will have an alpha without IBC yes. |
|
I'll update to https://github.com/cosmos/cosmos-sdk/releases/tag/v0.52.0-beta.2 before we should merge this. |
|
is there anything else blocking this branch? |
reviews :D and the message above |
|
moved back the target branch to main, as most tests are passing. |
| "cosmossdk.io/core/transaction" | ||
| banktypes "cosmossdk.io/x/bank/types" | ||
| staking "cosmossdk.io/x/staking/types" | ||
|
|
There was a problem hiding this comment.
remove and run make format
| // supply custom module basics | ||
| map[string]module.AppModuleBasic{ | ||
| genutiltypes.ModuleName: genutil.NewAppModuleBasic(genutiltypes.DefaultMessageValidator), | ||
| // this line is used by starport scaffolding # stargate/appConfig/moduleBasic |
There was a problem hiding this comment.
can we remove this placeholder from the rest of the code?
There was a problem hiding this comment.
looks like it wasn't existing, so nothing to here actually.
| @@ -69,15 +76,10 @@ func (app *App) prepForZeroHeightGenesis(ctx sdk.Context, jailAllowedAddrs []str | |||
| allowedAddrsMap[addr] = true | |||
There was a problem hiding this comment.
line 74 uses a log.Fatal instead panic
Yeah, the modules will be improved in a follow up. This is just so it builds and work (see check boxes from issue description) |
|
I'll do the linting in a follow-up. |
5 participants
v052 is getting audited, this is time for us to update modules and simapp to the latest version.
This PR focuses on: