-
Notifications
You must be signed in to change notification settings - Fork 576
feat(pkg): improve xgenny dry run (backport #4001) #4234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* run all dry runners before the we runners for the xgenny pkg * add changelog * Improve `xgenny` dry run * replace the last wet runners * create RunAndApply runner function * remove unused parameters from scaffold functions and fix wrong path for scaffold chain * run go mod tidy before go fmt * bump buf build * fix golden files for apps tests * create the runner target path if not exist * update go.mod * fix lint issue * fix doctor absolute path * re-organize xgenny pkg * fix lint warning --------- Co-authored-by: Pantani <Pantani> (cherry picked from commit 2ad41ee) # Conflicts: # ignite/cmd/chain.go # ignite/cmd/scaffold.go # ignite/cmd/scaffold_chain.go # ignite/cmd/scaffold_configs.go # ignite/cmd/scaffold_message.go # ignite/cmd/scaffold_module.go # ignite/cmd/scaffold_packet.go # ignite/cmd/scaffold_params.go # ignite/cmd/scaffold_query.go # ignite/pkg/xgenny/run.go # ignite/services/chain/init.go # ignite/services/chain/proto.go # ignite/services/doctor/doctor.go # ignite/services/scaffolder/configs.go # ignite/services/scaffolder/init.go # ignite/services/scaffolder/message.go # ignite/services/scaffolder/module.go # ignite/services/scaffolder/packet.go # ignite/services/scaffolder/params.go # ignite/services/scaffolder/query.go # ignite/services/scaffolder/scaffolder.go # ignite/services/scaffolder/type.go
|
Cherry-pick of 2ad41ee has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
Visit the preview URL for this PR (updated for commit c312a37): https://igntservices-docs--pr4234-mergify-bp-release-v-00v5xbcs.web.app (expires Thu, 11 Jul 2024 14:22:57 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 95379efd94dd497aaa37c2d0354e6e2cafca5ec5 |
* chore: bump buf build (#4002) * bump buf build * fix golden files for apps tests * add changelog --------- Co-authored-by: Pantani <Pantani> (cherry picked from commit 5c9966d) # Conflicts: # go.mod # go.sum * fix merge conflicts * fix changelog --------- Co-authored-by: Danilo Pantani <danpantani@gmail.com>
close #2565
Description
Improve the
xgennypackage by creating a custom runner to salve all modifications into a temporary folder and only apply and copy all files to the target directory later.Changes
This PR removes the default dry and wet runners, avoiding running two generators. If everything works fine, only one will run into a temporary folder and be copied to the target folder.
This is an automatic backport of pull request #4001 done by Mergify.