Skip to content

feat: remove all import placeholders using the xast pkg (backport #4004) - #4231

Closed
mergify[bot] wants to merge 4 commits into
release/v28.x.yfrom
mergify/bp/release/v28.x.y/pr-4004
Closed

feat: remove all import placeholders using the xast pkg (backport #4004)#4231
mergify[bot] wants to merge 4 commits into
release/v28.x.yfrom
mergify/bp/release/v28.x.y/pr-4004

Conversation

@mergify

@mergify mergify Bot commented Jul 2, 2024

Copy link
Copy Markdown
Contributor

Description

  • Remove all ignite placeholder into the .plush imports and add them using the xast.AppendImports function;
  • Remove the keeper definition placeholder into the app.go.plush and add them using the xast.ModifyFunction function;
  • Remove unused placeholders;
    This is an automatic backport of pull request feat: remove all import placeholders using the xast pkg #4004 done by Mergify.

* remove all import placeholders

* add changelog

* remove unused placeholders

* fix wrong import path

* improve readbility

* remove keeper definition placeholder

---------

Co-authored-by: Pantani <Pantani>
(cherry picked from commit 59400a5)

# Conflicts:
#	ignite/templates/ibc/placeholders.go
@mergify
mergify Bot requested review from ilgooz and salmad3 as code owners July 2, 2024 13:32
@mergify mergify Bot added the conflicts label Jul 2, 2024
@mergify

mergify Bot commented Jul 2, 2024

Copy link
Copy Markdown
Contributor Author

Cherry-pick of 59400a5 has failed:

On branch mergify/bp/release/v28.x.y/pr-4004
Your branch is up to date with 'origin/release/v28.x.y'.

You are currently cherry-picking commit 59400a52.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   changelog.md
	modified:   ignite/pkg/cosmosanalysis/app/testdata/modules/app_config/app_config.go
	modified:   ignite/pkg/cosmosanalysis/app/testdata/modules/spn/app.go
	modified:   ignite/pkg/cosmosanalysis/module/testdata/earth/app/app_config.go
	modified:   ignite/templates/app/files-minimal/app/app.go.plush
	modified:   ignite/templates/app/files-minimal/app/app_config.go.plush
	modified:   ignite/templates/app/files/app/app.go.plush
	modified:   ignite/templates/app/files/app/app_config.go.plush
	modified:   ignite/templates/app/files/app/ibc.go.plush
	modified:   ignite/templates/message/placeholders.go
	modified:   ignite/templates/module/create/base.go
	modified:   ignite/templates/module/create/files/base/x/{{moduleName}}/types/genesis.go.plush
	modified:   ignite/templates/module/create/ibc.go
	modified:   ignite/templates/module/placeholders.go
	modified:   ignite/templates/typed/genesis.go
	modified:   ignite/templates/typed/list/genesis.go
	modified:   ignite/templates/typed/map/map.go
	modified:   ignite/templates/typed/placeholders.go
	modified:   ignite/templates/typed/singleton/singleton.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   ignite/templates/ibc/placeholders.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@Pantani
Pantani marked this pull request as draft July 2, 2024 14:26
@julienrbrt

Copy link
Copy Markdown
Member

We shouldn't backport this. A chain scaffolded with v28 will still have the placeholders. I think it is more a v29 change

@Pantani Pantani self-assigned this Jul 3, 2024
@Pantani Pantani closed this Jul 3, 2024
@mergify
mergify Bot deleted the mergify/bp/release/v28.x.y/pr-4004 branch July 3, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants