feat: remove all import placeholders using the xast pkg (backport #4004) - #4231
Closed
mergify[bot] wants to merge 4 commits into
Closed
feat: remove all import placeholders using the xast pkg (backport #4004)#4231mergify[bot] wants to merge 4 commits into
xast pkg (backport #4004)#4231mergify[bot] wants to merge 4 commits into
Conversation
* remove all import placeholders * add changelog * remove unused placeholders * fix wrong import path * improve readbility * remove keeper definition placeholder --------- Co-authored-by: Pantani <Pantani> (cherry picked from commit 59400a5) # Conflicts: # ignite/templates/ibc/placeholders.go
mergify
Bot
requested review from
Pantani,
jeronimoalbi,
julienrbrt and
toschdev
as code owners
July 2, 2024 13:32
Contributor
Author
|
Cherry-pick of 59400a5 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Pantani
marked this pull request as draft
July 2, 2024 14:26
Member
|
We shouldn't backport this. A chain scaffolded with v28 will still have the placeholders. I think it is more a v29 change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
.plushimports and add them using thexast.AppendImportsfunction;app.go.plushand add them using thexast.ModifyFunctionfunction;This is an automatic backport of pull request feat: remove all import placeholders using the
xastpkg #4004 done by Mergify.