feat: set the proto-dir flag only for the scaffold chain command and use the proto path from the config - #4100
Merged
Merged
Conversation
Pantani
requested review from
ilgooz,
jeronimoalbi and
julienrbrt
as code owners
April 23, 2024 14:41
github-actions
Bot
added
component:ci
Pantani
marked this pull request as draft
April 23, 2024 14:51
Pantani
changed the title
proto-dir flag only for the scaffold chain command and use the proto path from the config
Pantani
marked this pull request as ready for review
April 24, 2024 00:43
julienrbrt
reviewed
Apr 24, 2024
julienrbrt
approved these changes
Apr 25, 2024
julienrbrt
pushed a commit
that referenced
this pull request
May 29, 2024
…and use the proto path from the config (#4100) * only use the proto dir from config * add proto dir only for scaffold a new chain * add changelog * fix integartion tests * remove unused flag from integration tests cmds * fix revive lint use * add a helper to find the root chain path * remove unused method * remove unused tests --------- Co-authored-by: Pantani <Pantani>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
proto-dirflag forscaffold chaincommand;