feat: support collections - #3707
Merged
Merged
Conversation
github-actions
Bot
added
component:ci
julienrbrt
force-pushed
the
julien/collections
branch
from
October 20, 2023 12:12
ca66861 to
e7dd485
Compare
Pantani
force-pushed
the
feat/sdk-v0.50
branch
2 times, most recently
from
November 9, 2023 17:40
cc7bd5e to
3a8e27d
Compare
julienrbrt
force-pushed
the
julien/collections
branch
from
November 20, 2023 13:39
7ebe7c7 to
1a489c5
Compare
julienrbrt
force-pushed
the
julien/collections
branch
from
November 25, 2023 19:55
b82c99f to
0675047
Compare
julienrbrt
force-pushed
the
julien/collections
branch
from
March 15, 2024 15:41
09fa806 to
9b447a3
Compare
Pantani
approved these changes
Mar 19, 2024
julienrbrt
enabled auto-merge (squash)
March 19, 2024 21:54
Member
Author
|
As discussed in the standup, let's as well investigate if we want to keep supporting multi index map. If not then I can bring back the changes I had here for maps and we have ignite totally using collections. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #3708
EDIT: I have reverted the scaffolding of map here: 3f1c59d as when having one index we should use Map and when using index we should use IndexedMap (with specific value codecs, index struct and different api in msg router) leading to too much complexity (just look at the commit -- and the indexmap wasn't logic wasn't even there let)