refactor: remove unecessary boilerplate in module #3673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
requested review from
Pantani,
ilgooz and
jeronimoalbi
as code owners
github-actions
bot
added
component:ci
julienrbrt
commented
Sep 27, 2023
Member
Author
There was a problem hiding this comment.
Renamed to proto because the MsgSignerOption isn't gogoproto related.
Pantani
approved these changes
Sep 29, 2023
Pantani
added a commit
that referenced
this pull request
Nov 20, 2023
* update go.sum * cosmos-sdk v0.50 imports * changes imports and update sdk * fix vet issues * fix unused imports * bump ibc * add changelog * update mocks * rollback some test changes * fix go version for the git workflows * fix wront tx result for abci tx * fix wrong test case * remove some legacy methods and add module import blank to the `app_config.go` * remove legacy amino and fix genesis commands * fix module orders * remove unused modules and commands * fix module imports * use statstore instead key and memory store * fix missing runtime import for test keepers * remove typo * fix missing imports * add msg signer option to the tx proto messages * add release branch to trigger tests * remove invalid test case * fix typo * fix missing create mesage option for single messages scaffold * Initialized with Ignite CLI * remove unused files * `--events` flag was moved to `--query` into `query tx` command * refactor: v0.50 store app wiring (#3672) * refactor: v0.50 store app wiring * updates * updates --------- Co-authored-by: Danilo Pantani <danpantani@gmail.com> * refactor: remove unecessary boilerplate in module (#3673) * refactor: remove unecessary boilerplate in module * updates --------- Co-authored-by: Danilo Pantani <danpantani@gmail.com> * refactor: simplify app.go (#3675) * refactor: simplify app.go * updates --------- Co-authored-by: Danilo Pantani <danpantani@gmail.com> * fix simulation types * fix query txs params * remove some empty lines * refactor: remove unecessary boilerplate (#3676) Co-authored-by: Danilo Pantani <danpantani@gmail.com> * update go.mod.plush * rollback go.mod changes * fix module discovery to use the keepers * bump sdk and ibc * find module per keeper * check blank imports * remove unused test data * remove old support methods and move module pkg to module folder * fix the module scaffold to find the module folder * add more test case and blank imports * use basepath instead roothopath * add pre blockers * fix cmd root_v2 * change ProvideClientContext to a pointer * remove unused unit tests and fix others * bump cosmos-sdk and run make format * fix root.go * fix wrong tx swagger generation * fix ibc module import * fix unit tests * fix app config for the unit tests * return ModuleCDC for ibc modules * fix capability keeper without app wiring * cleanup root.go and app.go * rollback txConfigOpts * use keepers injections as optional * fix error handler assign for sim tests * fix root sdk config call * skip lint cache * fix unit tests for app.go discovery * fix test data * add mmising interface methods for some tests * fix cosmosanalystis find implementation methods * fix ibc keepers for the testutil pkg * fix expected keepers injection conflict * remove unused expected keepers interfsces * fix capability keeper nullpointer for unit tests * fix module_ibc.go scaffolder * rollback sdk context * add creator options for packet msgs * bump cosmos-sdk * fix unhandled error * rollback lint version and improve app module comments * move appconfig inject to app.go * fix default test config * increase chain test timeout for integration * remove unused `go.sum` files * bump cosmos-sdk and ibc * fix network tests * add generic clenaup for the network config * add cfg addresses manually * avoid override config ports * add chain id and log format to tx integration test * add tx output * add json output for key query * bump ibc/capability and sdk/client * bum go dependencies * rollback not linux support dependency * bump ibc * regenerate mocks * docs: update tutorials to work with SDK `v0.50` (#3705) * chore: add `--chain-id` flag to blog commands * chore: use `cosmossdk.io/store` * chore: change blog tutorial to use the store service * chore: use `cosmossdk.io/errors` * chore: change "PostID" to "PostId" * chore: add missing import to code snippet * fix: correct expected keepers interface args * chore: add `--chain-id` flag to loan commands * ci: fix broken links * ci: fix broken references * ci: fix broken reference * chore: fix typo --------- Co-authored-by: Danilo Pantani <danpantani@gmail.com> * bum chain ibc * fix: fix ibc registration in 0.50 (#3758) * fix: fix ibc registration in 0.59 * updates * nit --------- Co-authored-by: Danilo Pantani <danpantani@gmail.com> * register capability module and fix genesis order * ibc params register --------- Co-authored-by: Pantani <Pantani> Co-authored-by: Developer Experience team at Ignite <hello@ignite.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Jerónimo Albi <jeronimo.albi@tendermint.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements to #3659.
I'll be submitting a few scoped PRs targeting that branch.
This PRs remove the legacy
Route()andType()from modules, as well as theGetSignersfunction.In v0.50
GetSignersis inferred from the proto annotation (that was added here: e52af75)