Skip to content

add snapcraft section - #297

Merged
ilgooz merged 2 commits into
masterfrom
alessio/snapcraft
Oct 8, 2020
Merged

ilgooz merged 2 commits into
masterfrom
alessio/snapcraft

Conversation

@alessio

@alessio alessio commented Oct 3, 2020

Copy link
Copy Markdown

cc @helder-moreira

  • Updated changelog.

@alessio
alessio requested a review from fadeev October 5, 2020 15:34
@helder-moreira
helder-moreira force-pushed the alessio/snapcraft branch 3 times, most recently from 24ca3ca to 7fb9b77 Compare October 6, 2020 12:22
@alessio
alessio marked this pull request as ready for review October 6, 2020 14:09
@alessio
alessio requested a review from ilgooz as a code owner October 6, 2020 14:09
@alessio
alessio requested a review from tac0turtle October 6, 2020 14:09
@fadeev

fadeev commented Oct 6, 2020

Copy link
Copy Markdown
Contributor

@ilgooz can you review this PR. We'll need to rerelease v0.11, is it possible to do?

ilgooz
ilgooz previously approved these changes Oct 7, 2020

@ilgooz ilgooz left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fadeev it would be much cleaner if we can issue another release but re-releasing is also possible 👍

@fadeev

fadeev commented Oct 7, 2020

Copy link
Copy Markdown
Contributor

@helder-moreira is it ok with Snapcraft if we release it as v0.11.1? Can you guys, please, handle this to the finish line 🙏

@helder-moreira

Copy link
Copy Markdown
Contributor

@faddat @ilgooz yes a new release would be great. Do you want me to rebase this on top of v0.11.0?

@ilgooz
ilgooz force-pushed the alessio/snapcraft branch from 7fb9b77 to 2c7c4ee Compare October 8, 2020 06:15
@alessio
alessio requested a review from lubtd as a code owner October 8, 2020 06:15
@ilgooz
ilgooz changed the base branch from develop to master October 8, 2020 06:15
@ilgooz

ilgooz commented Oct 8, 2020

Copy link
Copy Markdown
Contributor

Re-based and directly merging this to master to make a new release, thank you for adding snapcraft support guys!

@ilgooz
ilgooz merged commit 6316ad5 into master Oct 8, 2020
@ilgooz
ilgooz deleted the alessio/snapcraft branch October 8, 2020 06:17
faddat added a commit to faddat/starport that referenced this pull request Oct 13, 2020
…-fixes

# By Lucas Bertrand (2) and others
# Via GitHub (2) and İlker Göktuğ ÖZTÜRK (1)
* 'pi-fixes' of https://github.com/faddat/starport:
  add IBC (ignite#284)
  Add NFT tutorial (ignite#305)
  v0.11.1
  add snapcraft section (ignite#297)
  Refactor add into import in templates (ignite#308)
  Append ltacker to codeowners (ignite#306)
  Update readme (ignite#302)

Signed-off-by: Jacob Gadikian <jacobgadikian@gmail.com>

# Conflicts:
#	changelog.md
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
* add snapcraft section

* goreleaser: publish snap

Co-authored-by: Helder Moreira <helder.moreira@voluzi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants