Skip to content

fix(network): spinner issue for validator and coordinator commands #2939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 18, 2022
Merged

fix(network): spinner issue for validator and coordinator commands #2939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3955d27
fix 1
lumtis Oct 17, 2022
02232f7
Merge branch 'develop' into fix/network-spinner
lumtis Oct 17, 2022
3fa1c70
fix 2
lumtis Oct 17, 2022
22da91c
format
lumtis Oct 17, 2022
c1b0d8d
Merge branch 'develop' into fix/network-spinner
Oct 18, 2022
7d2f0bd
Merge branch 'develop' into fix/network-spinner
Oct 18, 2022
f963531
remove unnecessary
lumtis Oct 18, 2022
0fba03a
Merge branch 'develop' into fix/network-spinner
Oct 18, 2022
4919832
imports
lumtis Oct 18, 2022
9aa949b
Merge branch 'fix/network-spinner' of https://github.com/ignite/cli i…
lumtis Oct 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ignite/cmd/network_coordinator_set.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
profiletypes "github.com/tendermint/spn/x/profile/types"

"github.com/ignite/cli/ignite/pkg/cliui"
"github.com/ignite/cli/ignite/pkg/cliui/icons"
)

// NewNetworkCoordinatorSet creates a command to set an information in a coordinator profile
Expand All @@ -32,7 +33,7 @@ The following information can be set:
}

func networkCoordinatorSetHandler(cmd *cobra.Command, args []string) error {
session := cliui.New()
session := cliui.New(cliui.StartSpinner())
defer session.End()

nb, err := newNetworkBuilder(cmd, CollectEvents(session.EventBus()))
Expand All @@ -57,5 +58,9 @@ func networkCoordinatorSetHandler(cmd *cobra.Command, args []string) error {
return errors.New("invalid attribute, must provide details, identity, website or security")
}

return n.SetCoordinatorDescription(cmd.Context(), description)
if err := n.SetCoordinatorDescription(cmd.Context(), description); err != nil {
return err
}

return session.Printf("%s Coordinator updated \n", icons.OK)
}
2 changes: 1 addition & 1 deletion ignite/cmd/network_coordinator_show.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ func NewNetworkCoordinatorShow() *cobra.Command {
}

func networkCoordinatorShowHandler(cmd *cobra.Command, args []string) error {
session := cliui.New()
session := cliui.New(cliui.StartSpinner())
defer session.End()

nb, err := newNetworkBuilder(cmd, CollectEvents(session.EventBus()))
Expand Down
9 changes: 7 additions & 2 deletions ignite/cmd/network_validator_set.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
profiletypes "github.com/tendermint/spn/x/profile/types"

"github.com/ignite/cli/ignite/pkg/cliui"
"github.com/ignite/cli/ignite/pkg/cliui/icons"
)

// NewNetworkValidatorSet creates a command to set an information in a validator profile
Expand All @@ -33,7 +34,7 @@ The following information can be set:
}

func networkValidatorSetHandler(cmd *cobra.Command, args []string) error {
session := cliui.New()
session := cliui.New(cliui.StartSpinner())
defer session.End()

nb, err := newNetworkBuilder(cmd, CollectEvents(session.EventBus()))
Expand All @@ -60,5 +61,9 @@ func networkValidatorSetHandler(cmd *cobra.Command, args []string) error {
return errors.New("invalid attribute, must provide details, identity, website or security")
}

return n.SetValidatorDescription(cmd.Context(), validator)
if err := n.SetValidatorDescription(cmd.Context(), validator); err != nil {
return err
}

return session.Printf("%s Validator updated \n", icons.OK)
}
2 changes: 1 addition & 1 deletion ignite/cmd/network_validator_show.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ func NewNetworkValidatorShow() *cobra.Command {
}

func networkValidatorShowHandler(cmd *cobra.Command, args []string) error {
session := cliui.New()
session := cliui.New(cliui.StartSpinner())
defer session.End()

nb, err := newNetworkBuilder(cmd, CollectEvents(session.EventBus()))
Expand Down