feat: add --peer-address flag to network chain join command
#2921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeronimoalbi
requested review from
aljo242,
fadeev,
ilgooz,
lumtis and
tbruyelle
as code owners
|
@lubtd I added the flag during a debugging session and I thought of making a PR for it in case is something we want for the command, otherwise you can close it. |
tbruyelle
reviewed
Oct 14, 2022
tbruyelle
reviewed
Oct 14, 2022
Thanks for the PR. Yes, this feature is still highly since |
lumtis
suggested changes
Oct 14, 2022
added 3 commits
October 17, 2022 10:19
lumtis
previously approved these changes
Oct 17, 2022
tbruyelle
previously approved these changes
Oct 17, 2022
aljo242
approved these changes
Oct 17, 2022
tbruyelle
approved these changes
Oct 17, 2022
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
…te#2921) * feat: add `--peer-address` flag to `network chain join` command * chore: change join command to skip prompt when peer address flag is set Co-authored-by: Alex Johnson <alex@shmeeload.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR add a new
--peer-addressto thenetwork chain joincommand to allow users to skip the interactive "Peer's address" prompt.